Allow importing SamplerV1 and EstimatorV1 (Cherry-pick of #1477) #1478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Right now, users can't import `qiskit_ibm_runtime.SamplerV1` and `qiskit_ibm_runtime.EstimatorV1` because we only expose the aliases `Sampler` and `Estimator`. That gets in the way of users being explicit about which primitive version they're using. This also is resulting in the API docs not including the pages for both the V1 and V2 primitives in Qiskit/documentation#973 because we didn't tell autosummary about them.
Pull Request Test Coverage Report for Build 8175464133Details
💛 - Coveralls |
|
Isn't this a duplicate of #1477? |
|
Oops, I forgot to change the branch. Fixed. Thanks! |
|
I think this needs to go into 0.21.1 instead of just cherry picked into |
|
@jyu00 we need to cherry-pick to stable/0.21, then you/Kevin will need to make a 0.21.1 release from the stable/0.21 branch after. We can't cherry-pick a PR into a tag since a tag is a single snapshot in time. |
|
Yes you're right. Sorry it's been too long since I did a patch (or any) release. |
|
All good! @jyu00 can you please approve this so we can merge? |
kt474
approved these changes
Mar 6, 2024
|
Thanks @Eric-Arellano! I'll do a patch release today |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, users can't import
qiskit_ibm_runtime.SamplerV1andqiskit_ibm_runtime.EstimatorV1because we only expose the aliasesSamplerandEstimator. That gets in the way of users being explicit about which primitive version they're using.This also is resulting in the API docs not including the pages for both the V1 and V2 primitives in Qiskit/documentation#973 because we didn't tell autosummary about them.